[ 
https://issues.apache.org/jira/browse/FLINK-3460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156020#comment-15156020
 ] 

ASF GitHub Bot commented on FLINK-3460:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1683

    [FLINK-3460] [build] Set Flink dependencies in flink-streaming-connectors 
to provided

    The flink-streaming-connectors all depend on flink-streaming-java in 
compile scope.
    This entails that this dependency is always pulled in, when you build a fat 
jar. By
    setting this dependency to provided, this will be avoided. Furthermore, the 
connectors
    are always used in conjunction with flink-streaming-java. This means that 
you will
    always have an explicit dependency import of flink-streaming-java in your 
build script.
    This allows you to run your program locally but it is also easy to exclude 
the dependency
    from being included in the fat jar by setting it to provided, as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink providedDeps

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1683
    
----
commit fdfc046d5d349afc395cd09a682365b6746aedb3
Author: Till Rohrmann <trohrm...@apache.org>
Date:   2016-02-18T10:23:05Z

    [FLINK-3460] [build] Set Flink dependencies in flink-streaming-connectors 
to provided
    
    The flink-streaming-connectors all depend on flink-streaming-java in 
compile scope.
    This entails that this dependency is always pulled in, when you build a fat 
jar. By
    setting this dependency to provided, this will be avoided. Furthermore, the 
connectors
    are always used in conjunction with flink-streaming-java. This means that 
you will
    always have an explicit dependency import of flink-streaming-java in your 
build script.
    This allows you to run your program locally but it is also easy to exclude 
the dependency
    from being included in the fat jar by setting it to provided, as well.

----


> Make flink-streaming-connectors' flink dependencies provided
> ------------------------------------------------------------
>
>                 Key: FLINK-3460
>                 URL: https://issues.apache.org/jira/browse/FLINK-3460
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> All of the flink-streaming-connectors depend on flink-streaming-java (compile 
> scope). This entails that whenever you have a project which depends on the a 
> connector this will also pull in the heavy-weight flink-streaming-java 
> dependency. If you now build a fat-jar, you have to use exclusion rules to 
> filter them out again.
> It would be more natural to simply declare the dependencies as provided which 
> will automatically avoid the inclusion in the fat jar with respect to the 
> connector dependency. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to