Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1669#discussion_r53517217
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -1487,7 +1487,7 @@ class JobManager(
               }
             }
     
    -        eg.fail(cause)
    +        eg.cancel()
    --- End diff --
    
    I liked it that the job was not marked as "canceled()" (which gives no 
reason), but as failed, with a cause. The cause also shows up in the 
TaskManager logs, when the Task was "externally failed".
    
    Any specific reason that this changes? Is this currently inconsistent?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to