zentol commented on a change in pull request #13464: URL: https://github.com/apache/flink/pull/13464#discussion_r499365760
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceTracker.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.slotmanager; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.slots.ResourceRequirement; +import org.apache.flink.runtime.slots.ResourceRequirements; + +import java.util.Collection; +import java.util.Map; + +/** + * Tracks for each job how many resource are required/acquired. + */ +public interface ResourceTracker { + + /** + * Notifies the tracker about a new or updated {@link ResourceRequirements}. + * + * @param jobId the job that that the resource requirements belongs to + * @param resourceRequirements new resource requirements + */ + void notifyResourceRequirements(JobID jobId, Collection<ResourceRequirement> resourceRequirements); + + /** + * Notifies the tracker about the acquisition of a resource with the given resource profile, for the given job. + * + * @param jobId the job that acquired the resource + * @param resourceProfile profile of the resource + */ + void notifyAcquiredResource(JobID jobId, ResourceProfile resourceProfile); + + /** + * Notifies the tracker about the loss of a resource with the given resource profile, for the given job. + * + * @param jobId the job that lost the resource + * @param resourceProfile profile of the resource + */ + void notifyLostResource(JobID jobId, ResourceProfile resourceProfile); + + /** + * Returns a collection of {@link ResourceRequirements} that describe which resources the corresponding job is + * in need/excess of. Review comment: leftovers from a previous version where this method could return positive (==required) and negative (==excess) counts; will rename it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
