kl0u commented on a change in pull request #13502: URL: https://github.com/apache/flink/pull/13502#discussion_r496584609
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/WithBoundedness.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.transformations; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.source.Boundedness; + +/** + * An interface to be implemented by transformations that have explicitly set {@link Boundedness}. + * For now this is the {@link LegacySourceTransformation} and the {@link SourceTransformation}. + */ Review comment: Not sure if we will need it in the future. This is why I did not add it. I am not aware of any plans to support splitting the graph into subgraphs that are going to be independently scheduled. This is why I did not add it (I mentioned this option in the description of my PR as well). ########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/WithBoundedness.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.transformations; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.source.Boundedness; + +/** + * An interface to be implemented by transformations that have explicitly set {@link Boundedness}. + * For now this is the {@link LegacySourceTransformation} and the {@link SourceTransformation}. + */ Review comment: @aljoscha Do you think this should change and have it as a field in each `Transformation` and the pick the "global" runtime mode here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
