[ 
https://issues.apache.org/jira/browse/FLINK-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201320#comment-17201320
 ] 

Nicholas Jiang commented on FLINK-19124:
----------------------------------------

[~aljoscha]Sorry for the later pull request. Please help to review the changes 
for the getAccumulators() and getJobExecutionResult() without class loader 
parameter.

> Some JobClient methods are not ergonomic, require ClassLoader argument
> ----------------------------------------------------------------------
>
>                 Key: FLINK-19124
>                 URL: https://issues.apache.org/jira/browse/FLINK-19124
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>            Reporter: Aljoscha Krettek
>            Assignee: Nicholas Jiang
>            Priority: Major
>              Labels: pull-request-available, starter
>
> Both {{getAccumulators()}} and {{getJobExecutionResult()}} result require the 
> user to give a {{ClassLoader}}. In a lot of cases the {{JobClient}} is 
> created in a context where we already know the user-code {{ClassLoader}}. We 
> should see whether we can remove the class loader from those methods. This 
> might require that users give a class loader when constructing a 
> {{JobClient}} themselves for an already running job but the trade-off seems 
> to be worth it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to