leonardBang commented on a change in pull request #13128: URL: https://github.com/apache/flink/pull/13128#discussion_r492808746
########## File path: flink-connectors/flink-sql-connector-hbase-2.2/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,35 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.google.guava:guava:12.0.1 +- com.yammer.metrics:metrics-core:2.2.0 +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.3 +- io.netty:netty-all:4.1.44.Final +- org.apache.hbase:hbase-client:1.4.3 Review comment: Sorry let you misunderstand this. the NOTICE file is ok for 1.4, and for 2.2, we need to create a NOTICE file which follows the Flink notice style[1], I mean the content of NOTICE file could reference DEPENDENCIES. I write a NOTICE file[2] and pom.xml[3] for hbase 2 , you can reference it. [1]https://cwiki.apache.org/confluence/display/FLINK/Licensing# [2]https://github.com/leonardBang/flink/commit/52a9ba29e39bce32ca1df54cb6aa3dccc526b814 [3]https://github.com/leonardBang/flink/commit/52a9ba29e39bce32ca1df54cb6aa3dccc526b814#diff-c3a619ecb61e6012d47700b39c64e93c ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
