[ https://issues.apache.org/jira/browse/FLINK-19265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197346#comment-17197346 ]
Jiangjie Qin commented on FLINK-19265: -------------------------------------- Thanks for the suggestion, Stephan. I think that makes a lot of sense. We should add something like the following method in the SplitEnumeratorContext. {code} {{void finishSplitsAssignment(int subtask)}} {code} > Simplify handling of 'NoMoreSplitsEvent' > ---------------------------------------- > > Key: FLINK-19265 > URL: https://issues.apache.org/jira/browse/FLINK-19265 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common > Reporter: Stephan Ewen > Assignee: Stephan Ewen > Priority: Major > Fix For: 1.12.0 > > > Split assignment events are treated specially by the source API. Users do not > create them directly but call methods on the contexts to assign splits. > The {{NoMoreSplitsEvent}} is in contrast to that a custom user event and > needs to be handled like a custom event, when sent by enumerators and > received by the readers. > That seems a bit confusing and inconsistent, given that NoMoreSplits is > essential for all bounded stream use cases and is on the same level as the > {{AddSplitEvent}}. > I suggest that we treat "no more splits" similarly, by having either a custom > method or a custom "SplitAssignment" on the context and reader. > [~jqin] Curious what would be your take on this. -- This message was sent by Atlassian Jira (v8.3.4#803005)