XComp commented on a change in pull request #13316:
URL: https://github.com/apache/flink/pull/13316#discussion_r489347641
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerMetricsInfo.java
##########
@@ -58,8 +58,16 @@
public static final String FIELD_NAME_NETWORK_MEMORY_SEGMENTS_AVAILABLE
= "memorySegmentsAvailable";
+ public static final String FIELD_NAME_NETWORK_MEMORY_SEGMENTS_USED =
"memorySegmentsUsed";
Review comment:
I agree with you. But using `networkMemorySegmentsUsed` would mean that
we would have to rename `memorySegmentsAvailable` and `memorySegmentsTotal` as
well. I was hesitant to change already existing (and probably used) API
properties. Hence, I decided to stick to the naming pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
