KarmaGYZ commented on a change in pull request #13311:
URL: https://github.com/apache/flink/pull/13311#discussion_r488412282
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManagerFactory.java
##########
@@ -104,5 +104,5 @@ private Configuration
createActiveResourceManagerConfiguration(Configuration ori
resourceManagerMetricGroup);
}
- protected abstract ResourceManagerDriver<WorkerType>
createResourceManagerDriver(Configuration configuration);
+ protected abstract ResourceManagerDriver<WorkerType>
createResourceManagerDriver(Configuration configuration, String
webInterfaceUrl, String rpcAddress);
Review comment:
Not sure what you mean by introducing
`ActiveResourceManagerDriverFactory`, could you give more details about it?
IIUC, in that case, we need to let `KubernetesResourceManagerFactory`,
`YarnResourceManagerFactory`, and probably `MesosResourceManagerFactory` to
override the `createResourceManager` method, which will introduce lots of
duplicate logic.
BTW, in Mesos implementation, we need `webInterfaceUrl` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
