walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r487432460
##########
File path: docs/_includes/generated/execution_config_configuration.html
##########
@@ -106,6 +100,12 @@
<td>Boolean</td>
<td>Whether to compress spilled data. Currently we only support
compress spilled data for sort and hash-agg and hash-join operators.</td>
</tr>
+ <tr>
+ <td><h5>table.exec.state.ttl</h5><br> <span class="label
label-primary">Streaming</span></td>
+ <td style="word-wrap: break-word;">0 ms</td>
+ <td>Duration</td>
+ <td>Specifies a minimum time interval for how long idle state
(i.e. state which was not updated), will be retained. State will never be
cleared until it was idle for less than the minimum time, and will be cleared
at some time after it was idle. Default is never clean-up the state. NOTE:
Cleaning up state requires additional overhead for bookkeeping. Default value
is 0, which means that it will never clean up state.</td>
+ </tr>
Review comment:
not sure why but the doc generated by this PR actually preserves
alphabetical ordering
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
this is actually due to the fact that doc gen only regenerate files (and
if there's deletion, items will be deleted) but it doesn't remove htmls when
something is entirely removed. I manually removed this for one of my fault doc
gen
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
this is actually due to the fact that doc gen only regenerate files (and
if there's deletion, lines will be removed) but it doesn't remove the html when
all items in that file was removed. I manually removed this for one of my fault
doc gen
##########
File path: docs/_includes/generated/execution_config_configuration.html
##########
@@ -106,6 +100,12 @@
<td>Boolean</td>
<td>Whether to compress spilled data. Currently we only support
compress spilled data for sort and hash-agg and hash-join operators.</td>
</tr>
+ <tr>
+ <td><h5>table.exec.state.ttl</h5><br> <span class="label
label-primary">Streaming</span></td>
+ <td style="word-wrap: break-word;">0 ms</td>
+ <td>Duration</td>
+ <td>Specifies a minimum time interval for how long idle state
(i.e. state which was not updated), will be retained. State will never be
cleared until it was idle for less than the minimum time, and will be cleared
at some time after it was idle. Default is never clean-up the state. NOTE:
Cleaning up state requires additional overhead for bookkeeping. Default value
is 0, which means that it will never clean up state.</td>
+ </tr>
Review comment:
not sure why but the doc generated by this PR actually preserves
alphabetical ordering
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
this is actually due to the fact that doc gen only regenerate files (and
if there's deletion, items will be deleted) but it doesn't remove htmls when
something is entirely removed. I manually removed this for one of my fault doc
gen
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
this is actually due to the fact that doc gen only regenerate files (and
if there's deletion, lines will be removed) but it doesn't remove the html when
all items in that file was removed. I manually removed this for one of my fault
doc gen
##########
File path: docs/_includes/generated/execution_config_configuration.html
##########
@@ -106,6 +100,12 @@
<td>Boolean</td>
<td>Whether to compress spilled data. Currently we only support
compress spilled data for sort and hash-agg and hash-join operators.</td>
</tr>
+ <tr>
+ <td><h5>table.exec.state.ttl</h5><br> <span class="label
label-primary">Streaming</span></td>
+ <td style="word-wrap: break-word;">0 ms</td>
+ <td>Duration</td>
+ <td>Specifies a minimum time interval for how long idle state
(i.e. state which was not updated), will be retained. State will never be
cleared until it was idle for less than the minimum time, and will be cleared
at some time after it was idle. Default is never clean-up the state. NOTE:
Cleaning up state requires additional overhead for bookkeeping. Default value
is 0, which means that it will never clean up state.</td>
+ </tr>
Review comment:
not sure why but the doc generated by this PR actually preserves
alphabetical ordering
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
this is actually due to the fact that doc gen only regenerate files (and
if there's deletion, items will be deleted) but it doesn't remove htmls when
something is entirely removed. I manually removed this for one of my fault doc
gen
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
this is actually due to the fact that doc gen only regenerate files (and
if there's deletion, lines will be removed) but it doesn't remove the html when
all items in that file was removed. I manually removed this for one of my fault
doc gen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
