dawidwys commented on a change in pull request #13360:
URL: https://github.com/apache/flink/pull/13360#discussion_r486946393



##########
File path: docs/dev/connectors/kafka.md
##########
@@ -466,12 +445,12 @@ Through the producer record you can:
 ### Kafka Producers and Fault Tolerance
 
 <div class="codetabs" markdown="1">
-<div data-lang="Universal and 011" markdown="1">
-With Flink's checkpointing enabled, the `FlinkKafkaProducer011` 
(`FlinkKafkaProducer` for Kafka >= 1.0.0 versions) can provide
+<div data-lang="Universal" markdown="1">

Review comment:
       How about we remove the Tabs whatsoever? IMO it does not make sense 
anymore for a single connector.

##########
File path: docs/dev/connectors/kafka.md
##########
@@ -405,8 +385,7 @@ Consider setting appropriate [idelness timeouts]({{ 
site.baseurl }}/dev/event_ti
  
 ## Kafka Producer

Review comment:
       Shall we update the `Migrating Kafka Connector from 0.11 to universal` 
section? I think the approach recommended there is not valid (at least for the 
producer).

##########
File path: docs/dev/connectors/kafka.md
##########
@@ -48,34 +48,14 @@ For details on Kafka compatibility, please refer to the 
official [Kafka document
 </dependency>

Review comment:
       Shall we update the start of the section as well?
   
   ```
   Apache Flink ships with multiple Kafka connectors: universal, 0.10, and 0.11.
   ...
   However, for Kafka versions 0.11.x and 0.10.x, we recommend using the 
dedicated ``0.11`` and ``0.10`` connectors, respectively.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to