JingsongLi commented on a change in pull request #13010:
URL: https://github.com/apache/flink/pull/13010#discussion_r486047882
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGeneratorSource.java
##########
@@ -34,9 +39,19 @@
private static final long serialVersionUID = 1L;
+ private static final Logger LOG =
LoggerFactory.getLogger(DataGeneratorSource.class);
+
private final DataGenerator<T> generator;
+
private final long rowsPerSecond;
+ @Nullable
+ private Long numberOfRows;
+
+ private int outputSoFar;
Review comment:
transient
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGeneratorSource.java
##########
@@ -34,9 +39,19 @@
private static final long serialVersionUID = 1L;
+ private static final Logger LOG =
LoggerFactory.getLogger(DataGeneratorSource.class);
+
private final DataGenerator<T> generator;
+
private final long rowsPerSecond;
+ @Nullable
+ private Long numberOfRows;
+
+ private int outputSoFar;
+
+ private int toOutput;
Review comment:
transient
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/factories/datagen/RandomGeneratorVisitor.java
##########
@@ -0,0 +1,337 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.factories.datagen;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.streaming.api.functions.source.datagen.DataGenerator;
+import org.apache.flink.streaming.api.functions.source.datagen.RandomGenerator;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.data.DecimalData;
+import org.apache.flink.table.data.GenericArrayData;
+import org.apache.flink.table.data.GenericMapData;
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.factories.datagen.types.DataGeneratorMapper;
+import org.apache.flink.table.factories.datagen.types.RowDataGenerator;
+import org.apache.flink.table.types.logical.ArrayType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.CharType;
+import org.apache.flink.table.types.logical.DayTimeIntervalType;
+import org.apache.flink.table.types.logical.DecimalType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.MapType;
+import org.apache.flink.table.types.logical.MultisetType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TinyIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+import org.apache.flink.table.types.logical.YearMonthIntervalType;
+
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.math.RoundingMode;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+import static
org.apache.flink.table.factories.DataGenTableSourceFactory.FIELDS;
+import static
org.apache.flink.table.factories.DataGenTableSourceFactory.LENGTH;
+import static org.apache.flink.table.factories.DataGenTableSourceFactory.MAX;
+import static org.apache.flink.table.factories.DataGenTableSourceFactory.MIN;
+
+
+/**
+ * Creates a random {@link DataGeneratorContainer} for a particular logical
type.
+ */
+@Internal
+@SuppressWarnings("unchecked")
+public class RandomGeneratorVisitor extends DataGenVisitorBase {
+
+ public static final int RANDOM_STRING_LENGTH_DEFAULT = 100;
+
+ private static final int RANDOM_COLLECTION_LENGTH_DEFAULT = 3;
+
+ private final ConfigOptions.OptionBuilder minKey;
+
+ private final ConfigOptions.OptionBuilder maxKey;
+
+ public RandomGeneratorVisitor(String name, ReadableConfig config) {
+ super(name, config);
+
+ this.minKey = key(FIELDS + "." + name + "." + MIN);
+ this.maxKey = key(FIELDS + "." + name + "." + MAX);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(BooleanType booleanType) {
+ return
DataGeneratorContainer.of(RandomGenerator.booleanGenerator());
+ }
+
+ @Override
+ public DataGeneratorContainer visit(CharType booleanType) {
+ ConfigOption<Integer> lenOption = key(FIELDS + "." + name + "."
+ LENGTH)
+ .intType()
+ .defaultValue(RANDOM_STRING_LENGTH_DEFAULT);
+ return
DataGeneratorContainer.of(getRandomStringGenerator(config.get(lenOption)),
lenOption);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(VarCharType booleanType) {
+ ConfigOption<Integer> lenOption = key(FIELDS + "." + name + "."
+ LENGTH)
+ .intType()
+ .defaultValue(RANDOM_STRING_LENGTH_DEFAULT);
+ return
DataGeneratorContainer.of(getRandomStringGenerator(config.get(lenOption)),
lenOption);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(TinyIntType booleanType) {
+ ConfigOption<Integer> min = minKey.intType().defaultValue((int)
Byte.MIN_VALUE);
+ ConfigOption<Integer> max = maxKey.intType().defaultValue((int)
Byte.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.byteGenerator(
+ config.get(min).byteValue(),
config.get(max).byteValue()),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(SmallIntType booleanType) {
+ ConfigOption<Integer> min = minKey.intType().defaultValue((int)
Short.MIN_VALUE);
+ ConfigOption<Integer> max = maxKey.intType().defaultValue((int)
Short.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.shortGenerator(
+ config.get(min).shortValue(),
+ config.get(max).shortValue()),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(IntType integerType) {
+ ConfigOption<Integer> min =
minKey.intType().defaultValue(Integer.MIN_VALUE);
+ ConfigOption<Integer> max =
maxKey.intType().defaultValue(Integer.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.intGenerator(
+ config.get(min), config.get(max)),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(BigIntType bigIntType) {
+ ConfigOption<Long> min =
minKey.longType().defaultValue(Long.MIN_VALUE);
+ ConfigOption<Long> max =
maxKey.longType().defaultValue(Long.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.longGenerator(
+ config.get(min), config.get(max)),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(FloatType floatType) {
+ ConfigOption<Float> min =
minKey.floatType().defaultValue(Float.MIN_VALUE);
+ ConfigOption<Float> max =
maxKey.floatType().defaultValue(Float.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.floatGenerator(
+ config.get(min), config.get(max)),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(DoubleType doubleType) {
+ ConfigOption<Double> min =
minKey.doubleType().defaultValue(Double.MIN_VALUE);
+ ConfigOption<Double> max =
maxKey.doubleType().defaultValue(Double.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.doubleGenerator(
+ config.get(min), config.get(max)),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(DecimalType decimalType) {
+ ConfigOption<Double> min =
minKey.doubleType().defaultValue(Double.MIN_VALUE);
+ ConfigOption<Double> max =
maxKey.doubleType().defaultValue(Double.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ new BigDecimalRandomGenerator(
+
RandomGenerator.doubleGenerator(config.get(min), config.get(max)),
+ decimalType.getPrecision(),
decimalType.getScale()));
+ }
+
+ @Override
+ public DataGeneratorContainer visit(YearMonthIntervalType
yearMonthIntervalType) {
+ ConfigOption<Integer> min = minKey.intType().defaultValue(0);
+ ConfigOption<Integer> max =
maxKey.intType().defaultValue(120000); // Period max
+ return DataGeneratorContainer.of(
+ RandomGenerator.intGenerator(
+ config.get(min), config.get(max)),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(DayTimeIntervalType
dayTimeIntervalType) {
+ ConfigOption<Long> min =
minKey.longType().defaultValue(Long.MIN_VALUE);
+ ConfigOption<Long> max =
maxKey.longType().defaultValue(Long.MAX_VALUE);
+ return DataGeneratorContainer.of(
+ RandomGenerator.longGenerator(
+ config.get(min), config.get(max)),
+ min, max);
+ }
+
+ @Override
+ public DataGeneratorContainer visit(ArrayType arrayType) {
+ ConfigOption<Integer> lenOption = key(FIELDS + "." + name + "."
+ LENGTH)
+ .intType()
+ .defaultValue(RANDOM_COLLECTION_LENGTH_DEFAULT);
+
+ String fieldName = name + "." + "element";
+ DataGeneratorContainer container = arrayType
+ .getElementType()
+ .accept(new RandomGeneratorVisitor(fieldName, config));
+
+ DataGenerator<Object[]> generator =
RandomGenerator.arrayGenerator(container.getGenerator(), config.get(lenOption));
+ return DataGeneratorContainer.of(
+ new DataGeneratorMapper<>(generator,
(GenericArrayData::new)),
+ container.getOptions().toArray(new ConfigOption<?>[0]));
+ }
+
+ @Override
+ public DataGeneratorContainer visit(MultisetType multisetType) {
+ ConfigOption<Integer> lenOption = key(FIELDS + "." + name + "."
+ LENGTH)
+ .intType()
+ .defaultValue(RANDOM_COLLECTION_LENGTH_DEFAULT);
+
+ String fieldName = name + "." + "element";
+ DataGeneratorContainer container = multisetType
+ .getElementType()
+ .accept(new RandomGeneratorVisitor(fieldName, config));
+
+ DataGenerator<Map<Object, Integer>> mapGenerator =
RandomGenerator.mapGenerator(
+ container.getGenerator(),
+ RandomGenerator.intGenerator(0, 10),
+ config.get(lenOption));
+
+ return DataGeneratorContainer.of(
+ new DataGeneratorMapper<>(mapGenerator,
GenericMapData::new),
+ container.getOptions().toArray(new ConfigOption<?>[0]));
+ }
+
+ @Override
+ public DataGeneratorContainer visit(MapType mapType) {
+ ConfigOption<Integer> lenOption = key(FIELDS + "." + name + "."
+ LENGTH)
+ .intType()
+ .defaultValue(RANDOM_COLLECTION_LENGTH_DEFAULT);
+
+ String keyName = name + "." + "key";
+ String valName = name + "." + "value";
+
+ DataGeneratorContainer keyContainer = mapType
+ .getKeyType()
+ .accept(new RandomGeneratorVisitor(keyName, config));
+
+ DataGeneratorContainer valContainer = mapType
+ .getValueType()
+ .accept(new RandomGeneratorVisitor(valName, config));
+
+ Set<ConfigOption<?>> options = keyContainer.getOptions();
+ options.addAll(valContainer.getOptions());
+
+ DataGenerator<Map<Object, Object>> mapGenerator =
RandomGenerator.mapGenerator(
+ keyContainer.getGenerator(),
+ valContainer.getGenerator(),
+ config.get(lenOption));
+
+ return DataGeneratorContainer.of(
+ new DataGeneratorMapper<>(mapGenerator,
GenericMapData::new),
+ options.toArray(new ConfigOption<?>[0]));
+ }
+
+ @Override
+ public DataGeneratorContainer visit(RowType rowType) {
+ List<DataGeneratorContainer> fieldContainers =
rowType.getFields()
+ .stream()
+ .map(field -> {
+ String fieldName = name + "." + field.getName();
+ return field.getType().accept(new
RandomGeneratorVisitor(fieldName, config));
+ }).collect(Collectors.toList());
+
+ ConfigOption<?>[] options = fieldContainers
+ .stream()
+ .flatMap(container -> container.getOptions().stream())
+ .toArray(ConfigOption[]::new);
+
+ DataGenerator[] generators = fieldContainers
+ .stream()
+ .map(DataGeneratorContainer::getGenerator)
+ .toArray(DataGenerator[]::new);
+
+ String[] fieldNames = rowType.getFieldNames().toArray(new
String[0]);
+
+ return DataGeneratorContainer.of(new
RowDataGenerator(generators, fieldNames), options);
+ }
+
+ @Override
+ protected DataGeneratorContainer defaultMethod(LogicalType logicalType)
{
+ throw new ValidationException("Unsupported type: " +
logicalType);
+ }
+
+ private static RandomGenerator<StringData> getRandomStringGenerator(int
length) {
+ return new RandomGenerator<StringData>() {
+ @Override
+ public StringData next() {
+ return
StringData.fromString(random.nextHexString(length));
+ }
+ };
+ }
+
+ private static class BigDecimalRandomGenerator implements
DataGenerator<DecimalData> {
Review comment:
I think it can be named `DecimalDataRandomGenerator`
BigDecimal makes confused
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/factories/datagen/DataGenVisitorBase.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.factories.datagen;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.streaming.api.functions.source.datagen.DataGenerator;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.data.TimestampData;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.LocalZonedTimestampType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TimestampType;
+import org.apache.flink.table.types.logical.ZonedTimestampType;
+import org.apache.flink.table.types.logical.utils.LogicalTypeDefaultVisitor;
+
+import java.io.Serializable;
+import java.time.LocalDate;
+import java.time.LocalTime;
+import java.util.function.Supplier;
+
+import static java.time.temporal.ChronoField.MILLI_OF_SECOND;
+
+/**
+ * Base class for translating {@link LogicalType LogicalTypes} to {@link
DataGeneratorContainer}'s.
+ */
+public abstract class DataGenVisitorBase extends
LogicalTypeDefaultVisitor<DataGeneratorContainer> {
+
+ protected final String name;
+
+ protected final ReadableConfig config;
+
+ protected DataGenVisitorBase(String name, ReadableConfig config) {
+ this.name = name;
+ this.config = config;
+ }
+
+ @Override
+ public DataGeneratorContainer visit(DateType dateType) {
+ return DataGeneratorContainer.of(TimeGenerator.of(() -> (int)
LocalDate.now().toEpochDay()));
+ }
+
+ @Override
+ public DataGeneratorContainer visit(TimeType timeType) {
+ return DataGeneratorContainer.of(TimeGenerator.of(() ->
LocalTime.now().get(MILLI_OF_SECOND)));
Review comment:
Shouldn't this be `MILLI_OF_DAY`?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGeneratorSource.java
##########
@@ -34,9 +39,19 @@
private static final long serialVersionUID = 1L;
+ private static final Logger LOG =
LoggerFactory.getLogger(DataGeneratorSource.class);
+
private final DataGenerator<T> generator;
+
private final long rowsPerSecond;
+ @Nullable
+ private Long numberOfRows;
Review comment:
final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
