zhuzhurk commented on a change in pull request #13321:
URL: https://github.com/apache/flink/pull/13321#discussion_r485451228
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocatorTest.java
##########
@@ -224,6 +224,7 @@ public void testCoLocationConstraintThrowsException() {
final List<ExecutionVertexSchedulingRequirements>
schedulingRequirements = Collections.singletonList(
new ExecutionVertexSchedulingRequirements.Builder()
.withExecutionVertexId(new
ExecutionVertexID(new JobVertexID(), 0))
+ .withSlotSharingGroupId(new
SlotSharingGroupId())
Review comment:
Agreed. But I think we will be able to drop this builder along with
`ExecutionVertexSchedulingRequirements` when we drops all other
`ExecutionSlotAllocator` except for `SlotSharingExecutionSlotAllocator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
