rmetzger opened a new pull request #13355:
URL: https://github.com/apache/flink/pull/13355


   ## What is the purpose of the change
   
   Sometimes we can't unload the usercode classloader because there are still 
some references around that prevent garbage collection. 
   The FlinkKinesisProducer is causing such a problem. By adding the release 
hooks to Flink, we can register a hook for calling 
`AwsSdkMetrics.unregisterMetricAdminMBean()` prior to closing the classloader.
   
   This change only adds the hook into Flink, it does not yet register a hook 
for Kinesis, because there's another 
[problem](https://github.com/awslabs/amazon-kinesis-producer/issues/308) in 
Kinesis that we need to solve first.
   
   This work is based on a draft pull request: 
https://github.com/apache/flink/pull/12026
   
   
   ## Verifying this change
   
   - Added two new tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / *no*) -- no 
external deps changed
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (*yes* / no)
     - The serializers: (yes / *no* / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / *no* / 
don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / *no* / 
don't know)
     - The S3 file system connector: (yes / *no* / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (*yes* / no)
     - If yes, how is the feature documented? (not applicable / docs / 
*JavaDocs* / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to