zhijiangW commented on a change in pull request #13209:
URL: https://github.com/apache/flink/pull/13209#discussion_r484156753
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
##########
@@ -76,32 +76,68 @@
private final ShuffleMode shuffleMode;
- public StreamEdge(StreamNode sourceVertex, StreamNode targetVertex, int
typeNumber,
- List<String> selectedNames, StreamPartitioner<?>
outputPartitioner, OutputTag outputTag) {
- this(sourceVertex,
- targetVertex,
- typeNumber,
- selectedNames,
- outputPartitioner,
- outputTag,
- ShuffleMode.UNDEFINED);
- }
-
- public StreamEdge(StreamNode sourceVertex, StreamNode targetVertex, int
typeNumber,
- List<String> selectedNames, StreamPartitioner<?>
outputPartitioner, OutputTag outputTag,
- ShuffleMode shuffleMode) {
+ private long bufferTimeout;
+
+ public StreamEdge(
+ StreamNode sourceVertex,
+ StreamNode targetVertex,
+ int typeNumber,
+ List<String> selectedNames,
+ StreamPartitioner<?> outputPartitioner,
+ OutputTag outputTag) {
Review comment:
I guess we suggested two options here in the past.
- Add one more indentation to distinguish with below codes, as you suggested
above.
- Same indentation as this PR did, and add a separate empty line to
distinguish with below codes. And we can see that many existing class
constructors took this way, e.g. `Task`, `SingleInputGate`,
`RemoteInputChannel`, etc.
So I will keep the current way :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
