JingsongLi commented on a change in pull request #13144:
URL: https://github.com/apache/flink/pull/13144#discussion_r479982832
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveScalarFunction.java
##########
@@ -104,4 +114,66 @@ public Object eval(Object... args) {
* Evaluation logical, args will be wrapped when is a single array.
*/
protected abstract Object evalInternal(Object[] args);
+
+ private void setArguments(CallContext callContext) {
Review comment:
We can rename `HiveFunction` to `HiveLegacyFunction`, and create a new
abstract base class `HiveFunction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
