walterddr commented on a change in pull request #13163:
URL: https://github.com/apache/flink/pull/13163#discussion_r476778503
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXService.java
##########
@@ -85,6 +86,9 @@ private static JMXServer
startJMXServerWithPortRanges(Iterator<Integer> ports) {
while (ports.hasNext() && successfullyStartedServer == null) {
JMXServer server = new JMXServer();
int port = ports.next();
+ if (port == 0) { // try poke with a random port when
port is set to zero
Review comment:
actually with some consideration, I dont think this PR is even necessary
in a realistic stand point - setting the port to `"0"` vs setting it to some
port range is pretty much equal in a platform job management standpoint.
WRT the random port assignment, yeah I am not sure that's actually needed -
we didn't do a profiling.
I intent to close this PR and comment on the JIRA ticket if we all agree.
(thank you so much for chiming in and sharing your thoughts @tillrohrmann
@zentol :-) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
