rmetzger commented on pull request #13217: URL: https://github.com/apache/flink/pull/13217#issuecomment-680075151
Thanks a lot for your extensive and detailed review. It was very helpful for me! I have addressed most of you your comments. I extended the `DispatcherJobTest`. I'm in the process of testing if the refactoring to the client has introduced any new test failures, and I might clean up my new tests in `DispatcherJob` (I would thus recommend you to review them last). I might push a small change to the client code later today to better distinguish between initialization and runtime failures, so that we can solve the unstable `FunctionITCase.testInvalidUseOfTableFunction()` test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
