danny0405 commented on a change in pull request #13050:
URL: https://github.com/apache/flink/pull/13050#discussion_r476063925
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/Expander.java
##########
@@ -70,30 +75,43 @@ public static Expander create(FlinkPlannerImpl planner) {
/** Expands identifiers in a given SQL string, returning a {@link
Expanded}. */
public Expanded expanded(String ori) {
final Map<SqlParserPos, SqlIdentifier> identifiers = new
HashMap<>();
+ final Map<String, SqlIdentifier> funcNameToId = new HashMap<>();
Review comment:
Because the `BridgingSqlFunction` lost the parser position information.
We may need a refactor to `BridgingSqlFunction` but i don't want to in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
