pnowojski commented on a change in pull request #2: URL: https://github.com/apache/flink-benchmarks/pull/2#discussion_r475537292
########## File path: src/main/java/org/apache/flink/benchmark/UnalignedCheckpointBenchmark.java ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.benchmark; + +import org.apache.flink.api.common.functions.MapFunction; +import org.apache.flink.configuration.ConfigConstants; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.runtime.state.CheckpointListener; +import org.apache.flink.streaming.api.datastream.DataStreamSource; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.functions.sink.SinkFunction; +import org.apache.flink.streaming.api.functions.source.RichParallelSourceFunction; + +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Param; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.runner.Runner; +import org.openjdk.jmh.runner.RunnerException; +import org.openjdk.jmh.runner.options.Options; +import org.openjdk.jmh.runner.options.OptionsBuilder; +import org.openjdk.jmh.runner.options.VerboseMode; + +import java.io.IOException; + +import static java.util.concurrent.TimeUnit.HOURS; + +@OutputTimeUnit(HOURS) +public class UnalignedCheckpointBenchmark extends BenchmarkBase { Review comment: `@OperationsPerInvocation(NUM_FINISHED_CHECKPOINTS)`? ########## File path: src/main/java/org/apache/flink/benchmark/UnalignedCheckpointBenchmark.java ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.benchmark; + +import org.apache.flink.api.common.functions.MapFunction; +import org.apache.flink.configuration.ConfigConstants; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.runtime.state.CheckpointListener; +import org.apache.flink.streaming.api.datastream.DataStreamSource; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.functions.sink.SinkFunction; +import org.apache.flink.streaming.api.functions.source.RichParallelSourceFunction; + +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Param; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.runner.Runner; +import org.openjdk.jmh.runner.RunnerException; +import org.openjdk.jmh.runner.options.Options; +import org.openjdk.jmh.runner.options.OptionsBuilder; +import org.openjdk.jmh.runner.options.VerboseMode; + +import java.io.IOException; + +import static java.util.concurrent.TimeUnit.HOURS; + +@OutputTimeUnit(HOURS) +public class UnalignedCheckpointBenchmark extends BenchmarkBase { Review comment: nit: add a java doc that this benchmark checks for the time to perform a checkpoint? and/or maybe rename to `UnalignedCheckpointTimeBenchmark`? ########## File path: src/main/java/org/apache/flink/benchmark/RemoteChannelThroughputBenchmark.java ########## @@ -80,6 +84,7 @@ public void remoteRebalance(FlinkEnvironmentContext context) throws Exception { StreamExecutionEnvironment env = context.env; env.enableCheckpointing(CHECKPOINT_INTERVAL_MS); env.setParallelism(PARALLELISM); + env.getCheckpointConfig().enableUnalignedCheckpoints(!mode.equals("AlignedCheckpoint")); Review comment: Good idea for re-using this benchmark :) Before merging this, in order to preserve the benchmark continuity with the previous results, it would be a good idea to rename the `remoteRebalance` benchmark in the codespeed UI to `remoteRebalance.ALIGNED`. Alternatively after merging, we can remove the `remoteRebalance` benchmark from the UI to clean it up. ########## File path: src/main/java/org/apache/flink/benchmark/UnalignedCheckpointBenchmark.java ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.benchmark; + +import org.apache.flink.api.common.functions.MapFunction; +import org.apache.flink.configuration.ConfigConstants; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.runtime.state.CheckpointListener; +import org.apache.flink.streaming.api.datastream.DataStreamSource; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.functions.sink.SinkFunction; +import org.apache.flink.streaming.api.functions.source.RichParallelSourceFunction; + +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Param; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.runner.Runner; +import org.openjdk.jmh.runner.RunnerException; +import org.openjdk.jmh.runner.options.Options; +import org.openjdk.jmh.runner.options.OptionsBuilder; +import org.openjdk.jmh.runner.options.VerboseMode; + +import java.io.IOException; + +import static java.util.concurrent.TimeUnit.HOURS; + +@OutputTimeUnit(HOURS) +public class UnalignedCheckpointBenchmark extends BenchmarkBase { + private static final int NUM_VERTICES = 3; + private static final int PARALLELISM = 4; + private static final long CHECKPOINT_INTERVAL_MS = 10; + private static final int NUM_FINISHED_CHECKPOINTS = 5; + + public static void main(String[] args) throws RunnerException { + Options options = new OptionsBuilder() + .verbosity(VerboseMode.NORMAL) + .include(UnalignedCheckpointBenchmark.class.getCanonicalName()) + .build(); + + new Runner(options).run(); + } + + @Benchmark + public void unalignedCheckpoint(UnalignedCheckpointEnvironmentContext context) throws Exception { + StreamExecutionEnvironment env = context.env; + DataStreamSource<byte[]> source = env.addSource(new FiniteCheckpointSource(NUM_FINISHED_CHECKPOINTS)); + source + .slotSharingGroup("source").rebalance() + .map((MapFunction<byte[], byte[]>) value -> value).slotSharingGroup("map").rebalance() + .addSink(new SlowDiscardSink<>()).slotSharingGroup("sink"); + + env.execute(); + } + + public static class UnalignedCheckpointEnvironmentContext extends FlinkEnvironmentContext { + + @Param({"RemoteChannel", "LocalChannel"}) Review comment: `REMOTE`/`LOCAL`? ########## File path: src/main/java/org/apache/flink/benchmark/RemoteChannelThroughputBenchmark.java ########## @@ -48,6 +49,9 @@ private MiniCluster miniCluster; + @Param({"AlignedCheckpoint", "UnalignedCheckpoint"}) Review comment: `ALIGNED`/`UNALIGNED` to shorten the benchmark name plus to be consistent with the existing parameters (`ORDERED`/`UNORDERED`, `ROCKS`/`MEMORY`/`FS_ASYNC`/...)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
