dannycranmer commented on a change in pull request #13102:
URL: https://github.com/apache/flink/pull/13102#discussion_r475416784



##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -161,6 +163,30 @@ under the License.
                        <scope>provided</scope>
                </dependency>
 
+               <!-- Amazon AWS SDK v2.x dependencies -->
+               <dependency>
+                       <groupId>software.amazon.awssdk</groupId>
+                       <artifactId>kinesis</artifactId>
+                       <version>${aws.sdkv2.version}</version>
+               </dependency>
+
+               <dependency>
+                       <groupId>software.amazon.awssdk</groupId>
+                       <artifactId>netty-nio-client</artifactId>
+                       <version>${aws.sdkv2.version}</version>
+               </dependency>
+
+               <dependency>
+                       <groupId>software.amazon.awssdk</groupId>
+                       <artifactId>sts</artifactId>
+                       <version>${aws.sdkv2.version}</version>
+               </dependency>
+
+               <dependency>

Review comment:
       @xiaolong-sn I took a look into the error you reported. You were getting 
a Jackson error:
   
   ```
   Caused by: java.lang.NoSuchFieldError: NO_INTS
        at 
com.fasterxml.jackson.dataformat.cbor.CBORParser.<init>(CBORParser.java:285)
   ```
   
   Which is similar to [this error on 
stackoverflow](https://stackoverflow.com/questions/60756770/error-java-lang-nosuchfielderror-no-ints)
   
   And you fixed it by using:
   
   ```
   <dependency>
       <groupId>com.fasterxml.jackson.dataformat</groupId>
       <artifactId>jackson-dataformat-cbor</artifactId>
       <version>2.6.7</version>
   </dependency>
   ```
   
   I cannot replicate this issue, I can see that `jackson-dataformat-cbor` is 
pulled through three chains in a bare applications:
   - Flink @ 2.10.1 (https://github.com/apache/flink/blob/master/pom.xml#L126)
   - AWS SDK v1 @ 2.6.7 
(https://github.com/aws/aws-sdk-java/blob/master/pom.xml#L275)
   - AWS SDK v2 @ 2.10.4 
(https://github.com/aws/aws-sdk-java-v2/blob/master/pom.xml#L87)
   
   It is using the Flink managed version currently:
   - 
`com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.10.1:compile`
   
   I tried explicitly adding `2.6.7` but it seems this is banned:
   
   ```
   [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies 
failed with message:
   Found Banned Dependency: 
com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.6.7
   ```
   
   Can you please provide a minimal application where I can reproduce and test 
the problem? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to