dawidwys commented on a change in pull request #13050:
URL: https://github.com/apache/flink/pull/13050#discussion_r475400642



##########
File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/common/ViewsExpandingTest.scala
##########
@@ -20,9 +20,12 @@ package org.apache.flink.table.planner.plan.common
 
 import org.apache.flink.api.scala._
 import org.apache.flink.table.api._
-import org.apache.flink.table.catalog.{CatalogView, CatalogViewImpl, 
ObjectPath}
-import org.apache.flink.table.planner.utils.{TableTestBase, TableTestUtil, 
TableTestUtilBase}
+import org.apache.flink.table.catalog.{CatalogBaseTable, CatalogView, 
CatalogViewImpl, ObjectIdentifier, ObjectPath}
+import 
org.apache.flink.table.planner.runtime.stream.sql.FunctionITCase.PrimitiveScalarFunction

Review comment:
       Let's not import the `PrimitiveScalarFunction`. I don't think it makes 
sense to introduce a cross dependency between the tests. I think it is easy 
enough to add a simple function in this class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to