zentol commented on a change in pull request #13190:
URL: https://github.com/apache/flink/pull/13190#discussion_r473214901
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -51,10 +51,7 @@ public boolean isCompatibleWith(Configuration configuration)
{
@Override
public KubernetesClusterDescriptor
createClusterDescriptor(Configuration configuration) {
checkNotNull(configuration);
- if
(!configuration.contains(KubernetesConfigOptions.CLUSTER_ID)) {
- final String clusterId = generateClusterId();
-
configuration.setString(KubernetesConfigOptions.CLUSTER_ID, clusterId);
- }
+ ensureClusterIdIsSet(configuration);
return new KubernetesClusterDescriptor(configuration,
KubeClientFactory.fromConfiguration(configuration));
Review comment:
Yes I noticed that too, it is at odds with the interface. You can
connect to _any_ cluster, but only deploy a single one.
But this seems to be an issue of the `ClusterDescriptor` interface; there is
no way for implementations to accept additional arguments for deploying
clusters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
