wuchong commented on a change in pull request #13122:
URL: https://github.com/apache/flink/pull/13122#discussion_r472805841
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonFormatFactory.java
##########
@@ -56,16 +57,16 @@
@SuppressWarnings("unchecked")
@Override
public DecodingFormat<DeserializationSchema<RowData>>
createDecodingFormat(
- DynamicTableFactory.Context context,
- ReadableConfig formatOptions) {
+ DynamicTableFactory.Context context,
+ ReadableConfig formatOptions) {
Review comment:
Please keep indent for the method parameters.
Same to the following mehods.
##########
File path:
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/canal/CanalJsonSerDeserSchemaTest.java
##########
@@ -131,27 +131,72 @@ public void testDeserialization() throws Exception {
"-D(102,car battery,12V car battery,5.17)",
"-D(103,12-pack drill bits,12-pack of drill bits with
sizes ranging from #40 to #3,0.8)"
);
- assertEquals(expected, collector.list);
+ List<String> actual = collector.list.stream()
+ .map(Object::toString)
+ .collect(Collectors.toList());
+ assertEquals(expected, actual);
+
Review comment:
remove empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
