dianfu commented on a change in pull request #12770:
URL: https://github.com/apache/flink/pull/12770#discussion_r471253971
##########
File path: flink-python/pyflink/table/utils.py
##########
@@ -67,3 +67,7 @@ def tz_convert_to_internal(s, t: DataType, local_tz):
elif is_datetime64tz_dtype(s.dtype):
return s.dt.tz_convert(local_tz).dt.tz_localize(None)
return s
+
+
+def exec_insert_table(table, table_path) -> JobExecutionResult:
Review comment:
This method is only used in test cases and so I prefer to move it to
test_case_utils. I see it's also used in word_count.py, however, I suggest not
use it in word_count.py. This method isn't a public interface and we'd better
not exposing it to users. Use it in `word_count` will encourage users to use
this method directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
