KarmaGYZ commented on a change in pull request #11873:
URL: https://github.com/apache/flink/pull/11873#discussion_r471218269
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts
happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
Review comment:
Yes, that's a good point. However, it is currently used by production
code and a lot of testing code paths. I would move this issue out of the scope
of this PR. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
