rkhachatryan commented on a change in pull request #13110:
URL: https://github.com/apache/flink/pull/13110#discussion_r469069882
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -49,6 +51,18 @@
private final static int SERVER_PORT = NetUtils.getAvailablePort();
+ // see https://issues.apache.org/jira/browse/FLINK-18821
+ @Test(expected = IOException.class)
+ public void testFailureReportedToSubsequentRequests() throws Exception {
+ PartitionRequestClientFactory factory = new
PartitionRequestClientFactory(new FailingNettyClient());
+ try {
+ factory.createPartitionRequestClient(new
ConnectionID(new InetSocketAddress(InetAddress.getLocalHost(), 8080), 0));
+ } catch (IOException e) {
+ // expected
+ }
+ factory.createPartitionRequestClient(new ConnectionID(new
InetSocketAddress(InetAddress.getLocalHost(), 8080), 0));
Review comment:
You're right, but I think it's not very important in tests and 1.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
