wuchong commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r464833799
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -51,4 +52,24 @@ private TableConfigOptions() {}
.withDescription("The SQL dialect defines how to parse
a SQL query. " +
"A different SQL dialect may support
different SQL grammar. " +
"Currently supported dialects are:
default and hive");
+
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<String> LOCAL_TIME_ZONE =
key("table.local-time-zone")
+ .stringType()
+ // special value to decide whether to use
ZoneId.systemDefault() in TableConfig.getLocalTimeZone()
+ .defaultValue("System")
Review comment:
I think it would be better to use "default" as the default value here.
Because this is very easy to understand literally and `table.sql-dialect` also
uses it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
