rkhachatryan commented on a change in pull request #13045:
URL: https://github.com/apache/flink/pull/13045#discussion_r464442182
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointRequestDecider.java
##########
@@ -146,15 +151,11 @@
private Optional<CheckpointTriggerRequest> onTooEarly(long
nextTriggerDelayMillis) {
CheckpointTriggerRequest first = queuedRequests.first();
- if (first.isForce()) {
- return Optional.of(queuedRequests.pollFirst());
- } else if (first.isPeriodic) {
+ if (first.isPeriodic) {
Review comment:
Thanks, the table explains very clearly what `chooseRequestToExecute`
will return.
> I will remove all if from this function.
WDYT about removing the function (`onTooEarly`) at all? (and moving the two
remaining statements into `chooseRequestToExecute`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
