Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1612#discussion_r52388350
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
 ---
    @@ -141,9 +146,16 @@ public TaskDeploymentDescriptor(
                        List<BlobKey> requiredJarFiles, List<URL> 
requiredClasspaths,
                        int targetSlotNumber) {
     
    -           this(appId, jobID, vertexID, executionId, taskName, 
indexInSubtaskGroup, numberOfSubtasks, attemptNumber,
    -                           jobConfiguration, taskConfiguration, 
invokableClassName, producedPartitions,
    -                           inputGates, requiredJarFiles, 
requiredClasspaths, targetSlotNumber, null, -1);
    +           this(appId, jobID, vertexID, executionId, new 
ExecutionConfig(), taskName, indexInSubtaskGroup,
    --- End diff --
    
    This constructor only exists for tests. The executionConfig in the TDD is 
the change of this pull request, so here the new ExecutionConfig is just to not 
break the already existing tests that were testing other parts of the 
functionality of the TDD. New tests are added to test the new functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to