[ 
https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139530#comment-15139530
 ] 

ASF GitHub Bot commented on FLINK-3382:
---------------------------------------

Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/1614#issuecomment-182025617
  
    Shouldn't the current record remain valid if `hasNext()` returned true? I 
mean the user might be holding on to the object returned in `next`, and expect 
it to not be changed by a `hasNext` call:
    ```
    T cur = it.next();
    if(it.hasNext()) {
      // here, I would expect cur to not have changed since the next() call
    }
    ```


> Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
> -------------------------------------------------------------------------
>
>                 Key: FLINK-3382
>                 URL: https://issues.apache.org/jira/browse/FLINK-3382
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime
>    Affects Versions: 1.0.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> Object reuse in {{ReusingMutableToRegularIteratorWrapper.hasNext()}} can be 
> clarified by creating a single object and storing the iterator's next value 
> into the second reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to