austince commented on a change in pull request #12729: URL: https://github.com/apache/flink/pull/12729#discussion_r462315294
########## File path: flink-connectors/flink-connector-rabbitmq/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,9 @@ +flink-connector-rabbitmq +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.rabbitmq:amqp-client:4.2.0 Review comment: Ok great, thank you! Are the changes I listed in the source files themselves good enough for ASL license-compliance? Never modified source into a project of this scale before... ########## File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java ########## @@ -141,6 +140,25 @@ protected Connection setupConnection() throws Exception { return setupConnectionFactory().newConnection(); } + /** + * Initializes the consumer's {@link Channel}. If a prefetch count has been set in {@link RMQConnectionConfig}, + * the new channel will be use it for {@link Channel#basicQos(int)}. + * + * @param connection the consumer's {@link Connection}. + * @return the channel. + * @throws Exception if there is an issue creating or configuring the channel. + */ + protected Channel setupChannel(Connection connection) throws Exception { Review comment: I think both are great ideas, I'll implement those shortly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
