zhijiangW opened a new pull request #13013:
URL: https://github.com/apache/flink/pull/13013
## What is the purpose of the change
Assuming two remote channels with buffer managers as listeners in
LocalBufferPool, the deadlock happens as follows:
While the Canceler thread calling ch1#releaseAllResources, it will occupy
the bufferQueue lock of bm1 and try to call bm2#notifyBufferAvailable.
While the task thread recycling exclusive buffer for ch2, then it will
occupy the bufferQueue lock of bm2 and try to call bm1#notifyBufferAvailable.
These two threads will both occupy the respective bm's bufferQueue lock and
wait for other side's bufferQueue lock to cause deadlock.
Regarding the solution, we can check the released state outside of
bufferQueue lock in BufferManager#notifyBufferAvailable to return immediately.
## Brief change log
check the released state outside of bufferQueue lock in
BufferManager#notifyBufferAvailable to return immediately.
## Verifying this change
Verified by existing ITCase StreamFaultToleranceTestBase
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
