aljoscha commented on a change in pull request #12862:
URL: https://github.com/apache/flink/pull/12862#discussion_r452806811
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/UnnestTest.xml
##########
@@ -34,7 +34,7 @@ LogicalProject(a=[$0], s=[$3])
<Resource name="planAfter">
<![CDATA[
Calc(select=[a, f0 AS s])
-+- Correlate(invocation=[explode($cor0.c)],
correlate=[table(explode($cor0.c))], select=[a,b,c,f0],
rowType=[RecordType(INTEGER a, BIGINT b, VARCHAR(2147483647) ARRAY c,
VARCHAR(2147483647) f0)], joinType=[INNER])
Review comment:
Is `explode` the legacy name and that's why we're renaming them now?
That's probably independent of refactoring `UNNEST` to use the new type system,
isn't it?
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/LogicalUnnestRuleTest.xml
##########
@@ -37,7 +37,7 @@ LogicalProject(a=[$0], s=[$3])
+- LogicalCorrelate(correlation=[$cor0], joinType=[inner],
requiredColumns=[{2}])
:- LogicalTableScan(table=[[default_catalog, default_database, MyTable,
source: [TestTableSource(a, b, c)]]])
+- LogicalProject(s=[$0])
- +- LogicalTableFunctionScan(invocation=[explode($cor0.c)],
rowType=[RecordType(VARCHAR(2147483647) f0)], elementType=[class
[Ljava.lang.Object;])
Review comment:
Same question for the `explode` vs `UNNEST`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
