danny0405 commented on pull request #12819: URL: https://github.com/apache/flink/pull/12819#issuecomment-656048735
> After reading the discussion of https://issues.apache.org/jira/browse/CALCITE-4107, I think we should re-think the solution. I agree RANK & DENSE_RANK shouldn't allow ROWS or RANGE, and our queries do not contain ROWS and RANGE. So, `allowsFraming` is not the correct fixing way. > > cc @danny0405 Could you help to investigate this? Sure, let me take a look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org