wuchong commented on a change in pull request #12805:
URL: https://github.com/apache/flink/pull/12805#discussion_r451950734
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaOptions.java
##########
@@ -222,8 +226,17 @@ private static void validateSinkSemantic(ReadableConfig
tableOptions) {
// Utilities
//
--------------------------------------------------------------------------------------------
- public static String transformSemantic(String semantic){
- return semantic.toUpperCase().replace('-', '_');
+ public static KafkaSemantic getSinkSemantic(String semantic){
Review comment:
`SinkSemantic` or `KafkaSinkSemantic`? It maybe confusing that it also
works for source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
