dannycranmer opened a new pull request #12850:
URL: https://github.com/apache/flink/pull/12850


   ## What is the purpose of the change
   
   Improved test coverage for existing `FlinkKinesisConsumer` polling 
consumption implementation (`ShardConsumer`).
   
   ## Brief change log
   
     - Add tests for consumption of aggregated records
     - Add tests for resuming consumption from an aggregated sub-sequence number
     - Add assertions on `ShardIteratorType` for existing `ShardConsumerTest` 
methods
     - Existing code in `ShardConsumerTest` had high duplication, this has been 
extracted to a method
   
   Note: Source code has not be modified, only test code.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - Running unit tests for `flink/flink-connectors/flink-connector-kinesis`, 
specifically:
     -- `ShardConsumerTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     -- I have added a **test scoped** dependency on 
[amazon-kinesis-aggregator](https://github.com/awslabs/kinesis-aggregation) to 
perform record aggregation
     -- License: [Apache 
2.0](https://github.com/awslabs/kinesis-aggregation/blob/master/LICENSE.txt)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`:  no
     - The serializers: no 
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to