fsk119 commented on a change in pull request #12756:
URL: https://github.com/apache/flink/pull/12756#discussion_r450836591
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -444,10 +444,9 @@ private Date convertToDate(ObjectMapper mapper, JsonNode
jsonNode) {
}
private LocalDateTime convertToLocalDateTime(ObjectMapper mapper,
JsonNode jsonNode) {
- // according to RFC 3339 every date-time must have a timezone;
- // until we have full timezone support, we only support UTC;
- // users can parse their time as string as a workaround
- TemporalAccessor parsedTimestamp =
RFC3339_TIMESTAMP_FORMAT.parse(jsonNode.asText());
+ // The input of Time can't contain any zone info
+ // Users have to cast time with zone into local time manually.
+ TemporalAccessor parsedTimestamp =
ISO8601_TIMESTAMP_FORMAT.parse(jsonNode.asText());
Review comment:
Sorry, I made a mistake. I will rollback it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
