austince commented on a change in pull request #12056:
URL: https://github.com/apache/flink/pull/12056#discussion_r447322135
##########
File path:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
##########
@@ -77,6 +78,7 @@
private final RMQConnectionConfig rmqConnectionConfig;
protected final String queueName;
private final boolean usesCorrelationId;
+ protected RMQDeserializationSchema<OUT> deliveryDeserializer;
protected DeserializationSchema<OUT> schema;
Review comment:
I think `static` is better just because there's no need to access any
class fields or methods from within this. Probably could go either way, I'm no
Java expert either!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
