wanglijie95 commented on pull request #12754: URL: https://github.com/apache/flink/pull/12754#issuecomment-648976755
> Thanks for the fix! I think, however, that `WindowOperatorTest` is not the right place to put the test, it should be added in `ContinuousProcessingTimeTriggerTest`. I know that the fix for `ContinuousEventTimeTrigger` also made this mistake but we should now fix it. For this you would first need to add the `Test`, you can do this based on `ContinuousEventTimeTriggerTest` and then add a new test for this fix there. What do you think? Thanks for review! You are right, `ContinuousProcessingTimeTriggerTest` is more suitable. I will change it later. As for the mistake maded by the fix for `ContinuousEventTimeTrigger`, I think it should be fixed in a new PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
