godfreyhe commented on a change in pull request #12750:
URL: https://github.com/apache/flink/pull/12750#discussion_r444081509



##########
File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala
##########
@@ -71,9 +75,23 @@ class TableEnvironmentITCase(tableEnvName: String, 
isStreaming: Boolean) extends
     tableEnvName match {
       case "TableEnvironment" =>
         tEnv = TableEnvironmentImpl.create(settings)
+        if (isStreaming) {
+          tEnv.getConfig.getConfiguration.set(
+            ExecutionCheckpointingOptions.CHECKPOINTING_MODE,
+            CheckpointingMode.EXACTLY_ONCE)
+          tEnv.getConfig.getConfiguration.set(
+            ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL,
+            
Duration.ofMillis(CheckpointCoordinatorConfiguration.MINIMAL_CHECKPOINT_TIME)
+          )
+        }
       case "StreamTableEnvironment" =>
-        tEnv = StreamTableEnvironment.create(
-          StreamExecutionEnvironment.getExecutionEnvironment, settings)
+        val execEnv = StreamExecutionEnvironment.getExecutionEnvironment
+        tEnv = StreamTableEnvironment.create(execEnv, settings)
+        if (isStreaming) {

Review comment:
       also use `tEnv.getConfig.getConfiguration.set()` ? then we can move them 
into one place




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to