[jira] [Commented] (FLINK-16835) Replace TableConfig with Configuration

[Fabian Hueske (Jira)]

    [ 
https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142693#comment-17142693
 ] 

Fabian Hueske commented on FLINK-16835:
---------------------------------------

Thanks for the feedback [~twalthr].
So the options are even more condensed to:

{code:java}
  public static final ConfigOption<Duration> IDLE_STATE_RETENTION =
      key("table.exec.state.ttl")
          .durationType()
          .defaultValue(Duration.ofMillis(0));

  public static final ConfigOption<Integer> MAX_LENGTH_GENERATED_CODE =
      key("table.generated-code.max-length")
          .intType()
          .defaultValue(64000);

  public static final ConfigOption<String> LOCAL_TIME_ZONE =
      key("table.local-time-zone")
          .stringType()
          .defaultValue(ZoneId.systemDefault().toString());
{code}

> Replace TableConfig with Configuration
> --------------------------------------
>
>                 Key: FLINK-16835
>                 URL: https://issues.apache.org/jira/browse/FLINK-16835
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: Timo Walther
>            Priority: Major
>
> In order to allow reading and writing of configuration from a file or 
> string-based properties. We should consider removing {{TableConfig}} and 
> fully rely on a Configuration-based object with {{ConfigOptions}}.
> This effort was partially already started which is why 
> {{TableConfig.getConfiguration}} exists.
> However, we should clarify if we would like to have control and traceability 
> over layered configurations such as {{flink-conf,yaml < 
> StreamExecutionEnvironment < TableEnvironment < Query}}. Maybe the 
> {{Configuration}} class is not the right abstraction for this. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)