Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-179949096
Following your suggestions, thanks.
* squash: should I squash the commits coming from the review as well?
* tests: I thought it was about some Travis configuration on our fork, I'll
have to look into it
* docs: thanks for pointing out the documentation, I missed it!
* get: I'm not sure about it, I think it would be cleaner logically but it
would make the `params` checking a little bit heavier on the reader â I can
work on that but I'd wrap the parameter checking in a `checkParameters` method
that is used for the initial checking and the one in the `get*` methods, would
that work for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
