aljoscha commented on pull request #12726: URL: https://github.com/apache/flink/pull/12726#issuecomment-647621155
The build fails because of unused imports, could you please fix those. Thanks for discovering this problem! I think the design is not optimal here because it can happen that during a batch we add more failed requests to the buffer. Ideally, we would have designed the sink in such a way that we can do things without a concurrent queue. However, I think with the current design it's ok to change it to a concurrent queue here. Side node: I'm not 100 % sure this sink works correctly because of the many concurrent things going on. Not saying that there are problems, just that I don't know. 😅 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
