[ 
https://issues.apache.org/jira/browse/FLINK-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131659#comment-15131659
 ] 

ASF GitHub Bot commented on FLINK-2678:
---------------------------------------

Github user sbcd90 commented on the pull request:

    https://github.com/apache/flink/pull/1566#issuecomment-179599473
  
    Hello @tillrohrmann  ..I have made all the changes you have mentioned.
    
    - support for CompositeType.
    - added test cases for both primitive type & composite type
    - modified the changed test case in DataSinkTest.java
    - changed the name of Comparator to ObjectArrayComparator.java
    - javadocs are auto-generated by intellij.
    
    Please please please please review my code now. Kindly let me know if there 
are any further changes required. Kindly let me know if this can be merged now 
also.


> DataSet API does not support multi-dimensional arrays as keys
> -------------------------------------------------------------
>
>                 Key: FLINK-2678
>                 URL: https://issues.apache.org/jira/browse/FLINK-2678
>             Project: Flink
>          Issue Type: Wish
>          Components: DataSet API
>            Reporter: Till Rohrmann
>            Assignee: Subhobrata Dey
>            Priority: Minor
>
> The DataSet API does not support grouping/sorting on field which are 
> multi-dimensional arrays. It could be helpful to also support these types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to