protos37 commented on a change in pull request #12680: URL: https://github.com/apache/flink/pull/12680#discussion_r442082402
########## File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/over/RowTimeRangeBoundedPrecedingFunctionTest.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.over; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.runtime.state.AbstractKeyedStateBackend; +import org.apache.flink.streaming.api.operators.KeyedProcessOperator; +import org.apache.flink.streaming.api.watermark.Watermark; +import org.apache.flink.streaming.util.KeyedOneInputStreamOperatorTestHarness; +import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.generated.AggsHandleFunction; +import org.apache.flink.table.runtime.generated.GeneratedAggsHandleFunction; +import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector; +import org.apache.flink.table.types.logical.BigIntType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.VarCharType; + +import org.junit.Test; + +import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord; +import static org.junit.Assert.assertEquals; + +/** + * Test for {@link RowTimeRangeBoundedPrecedingFunction}. + */ +public class RowTimeRangeBoundedPrecedingFunctionTest { + + private static GeneratedAggsHandleFunction aggsHandleFunction = + new GeneratedAggsHandleFunction("Function", "", new Object[0]) { + @Override + public AggsHandleFunction newInstance(ClassLoader classLoader) { + return new SumAggsHandleFunction(1); + } + }; + + private LogicalType[] inputFieldTypes = new LogicalType[]{ + new VarCharType(VarCharType.MAX_LENGTH), + new BigIntType(), + new BigIntType() + }; + private LogicalType[] accTypes = new LogicalType[]{ new BigIntType() }; + + private BinaryRowDataKeySelector keySelector = new BinaryRowDataKeySelector(new int[]{ 0 }, inputFieldTypes); + private TypeInformation<RowData> keyType = keySelector.getProducedType(); + + @Test + public void testRecordRetraction() throws Exception { Review comment: I have been intentionally using the term "retract" to distinguish the cleanup from cleanup by ttl. `testStateCleanup()` should be an appropriate name especially after removing state ttl from functions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
