rkhachatryan commented on a change in pull request #12575:
URL: https://github.com/apache/flink/pull/12575#discussion_r440653529
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##########
@@ -46,14 +49,8 @@
private static final Logger LOG =
LoggerFactory.getLogger(CheckpointBarrierAligner.class);
- /** Used to get InputGate by channel index. */
- private final InputGate[] channelIndexToInputGate;
-
- /** Used to get channel index offset by InputGate. */
- private final Map<InputGate, Integer> inputGateToChannelIndexOffset;
-
/** Flags that indicate whether a channel is currently
blocked/buffered. */
- private final boolean[] blockedChannels;
+ private final Map<InputChannelInfo, Boolean> blockedChannels;
Review comment:
Why do we use `Map<Key, Boolean>` instead of just `Set<Key>` (also in
`CheckpointBarrierUnaligner`, `ThreadSafeUnaligner`)?
(I guess we can avoid the penalty of dynamic reallocation by setting set
capacity in advance)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
