[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

[GitBox]

zhijiangW commented on a change in pull request #12664:
URL: https://github.com/apache/flink/pull/12664#discussion_r440578551



##########
File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java
##########
@@ -218,6 +230,67 @@ public void testNotifyCheckpointAbortedBeforeAsyncPhase() 
throws Exception {
                assertEquals(0, 
subtaskCheckpointCoordinator.getAsyncCheckpointRunnableSize());
        }
 
+       @Test
+       public void 
testDownstreamReceiveCancelCheckpointMarkerOnUpstreamAbortedInSyncPhase() 
throws Exception {
+               final OneInputStreamTaskTestHarness<String, String> testHarness 
=
+                       new OneInputStreamTaskTestHarness<>(
+                               OneInputStreamTask::new,
+                               1, 1,

Review comment:
       nit: separate line for every argument




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org