azagrebin commented on a change in pull request #12278:
URL: https://github.com/apache/flink/pull/12278#discussion_r438824119
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -648,26 +648,8 @@ boolean offerSlot(
slotOffer.getResourceProfile(),
taskManagerGateway);
- // check whether we have request waiting for this slot
- PendingRequest pendingRequest =
pendingRequests.removeKeyB(allocationID);
Review comment:
Ok, the FLINK-13165 makes slot requests to be completed in order only if
the offers come with unknown `AllocationIds`, right? Generally we expect that
RM keeps the `AllocationId` to match `SlotRequestID`. I am fine to break the
tie `SlotRequestId->AllocationID` if there is no known consequences.
Eventually, I hope it might even help to simplify the `SlotPoolImpl`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
