libenchao commented on a change in pull request #11359:
URL: https://github.com/apache/flink/pull/11359#discussion_r437517254
##########
File path: docs/dev/table/modules.zh.md
##########
@@ -22,51 +22,41 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
+模块让用户能够对 Flink 内置对象进行扩展。例如定义一些类似Flink内置函数的函数。模块是可插拔的，Flink
已经提供了一些预构建的模块，用户还可以实现自己的模块。
-Modules allow users to extend Flink's built-in objects, such as defining
functions that behave like Flink
-built-in functions. They are pluggable, and while Flink provides a few
pre-built modules, users can write
-their own.
-
-For example, users can define their own geo functions and plug them into Flink
as built-in functions to be used in
-Flink SQL and Table APIs. Another example is users can load an out-of-shelf
Hive module to use Hive built-in
-functions as Flink built-in functions.
+例如，用户可以自定义 geo 函数，并将其作为内置函数插入 Flink，随后就可以在 Flink SQL 和 Table API
中使用它了。另一个示例是，用户可以加载现成的 Hive 模块，随后就可以像使用 Flink 内置函数一样使用 Hive 模块的函数了。
Review comment:
geo 函数，感觉geo是不是可以翻译出来？
##########
File path: docs/dev/table/modules.zh.md
##########
@@ -22,51 +22,41 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
+模块让用户能够对 Flink 内置对象进行扩展。例如定义一些类似Flink内置函数的函数。模块是可插拔的，Flink
已经提供了一些预构建的模块，用户还可以实现自己的模块。
Review comment:
```suggestion
模块让用户能够对 Flink 内置对象进行扩展。例如定义一些类似 Flink 内置函数的函数。模块是可插拔的，Flink
已经提供了一些预构建的模块，用户还可以实现自己的模块。
```
##########
File path: docs/dev/table/modules.zh.md
##########
@@ -76,31 +66,31 @@ tableEnv.unloadModule("myModule");
{% endhighlight %}
</div>
<div data-lang="YAML" markdown="1">
+使用YAML定义的模块必须设置`类型`属性来指定模块类型。原生支持以下模块类型。
-All modules defined using YAML must provide a `type` property that specifies
the type.
-The following types are supported out of the box.
<table class="table table-bordered">
<thead>
<tr>
- <th class="text-center" style="width: 25%">Catalog</th>
- <th class="text-center">Type Value</th>
+ <th class="text-center" style="width: 25%">模块种类</th>
+ <th class="text-center">类型值</th>
</tr>
</thead>
<tbody>
<tr>
- <td class="text-center">CoreModule</td>
+ <td class="text-center">核心模块</td>
<td class="text-center">core</td>
</tr>
<tr>
- <td class="text-center">HiveModule</td>
+ <td class="text-center">Hive模块</td>
<td class="text-center">hive</td>
</tr>
</tbody>
</table>
{% highlight yaml %}
modules:
+
Review comment:
why add this blank line?
##########
File path: docs/dev/table/modules.zh.md
##########
@@ -76,31 +66,31 @@ tableEnv.unloadModule("myModule");
{% endhighlight %}
</div>
<div data-lang="YAML" markdown="1">
+使用YAML定义的模块必须设置`类型`属性来指定模块类型。原生支持以下模块类型。
-All modules defined using YAML must provide a `type` property that specifies
the type.
-The following types are supported out of the box.
<table class="table table-bordered">
<thead>
<tr>
- <th class="text-center" style="width: 25%">Catalog</th>
- <th class="text-center">Type Value</th>
+ <th class="text-center" style="width: 25%">模块种类</th>
+ <th class="text-center">类型值</th>
</tr>
</thead>
<tbody>
<tr>
- <td class="text-center">CoreModule</td>
+ <td class="text-center">核心模块</td>
<td class="text-center">core</td>
</tr>
<tr>
- <td class="text-center">HiveModule</td>
+ <td class="text-center">Hive模块</td>
Review comment:
```suggestion
<td class="text-center">Hive 模块</td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
